feat(#2361): increase clickable area for radio and checkbox #3099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syedszeeshan
force-pushed
the
Syed/2361-UI-clickablearea
branch
2 times, most recently
from
5d8fd63 to
79bcb45
Compare
syedszeeshan
changed the title
syedszeeshan
force-pushed
the
Syed/2361-UI-clickablearea
branch
from
79bcb45 to
ef25ab4
Compare
ArakTaiRoth
reviewed
Oct 22, 2025
| // - matrix\(1, 0, 0, 1, = identity matrix | ||
| // - -2[0-9.]+ = negative number starting with -2 (e.g., -22, -23.6) | ||
| // - Flexible pattern accounts for border widths and sub-pixel rendering | ||
| expect(beforeStyles.transform).toMatch(/matrix\(1, 0, 0, 1, -2[0-9.]+, -2[0-9.]+\)/); |
Collaborator
There was a problem hiding this comment.
This is extremely specific and I think very brittle. After the tests above, I'm not sure this is adding anything useful, and would make the test far more brittle than I would like.
ArakTaiRoth
reviewed
Oct 22, 2025
| // - (-22, -22) = translate by -22px in X and Y directions | ||
| // Math: 50% of 44px = 22px, so translate(-50%, -50%) = translate(-22px, -22px) | ||
| // This centers the 44px touch target on the 24px icon | ||
| expect(beforeStyles.transform).toBe("matrix(1, 0, 0, 1, -22, -22)"); |
Collaborator
There was a problem hiding this comment.
Same comment as the one I made for the Checkbox tests
chrisolsen
force-pushed
the
Syed/2361-UI-clickablearea
branch
from
e15a64e to
f25d568
Compare
chrisolsen
approved these changes
Nov 20, 2025
vanessatran-ddi
approved these changes
Nov 20, 2025
Collaborator
|
🎉 This PR is included in version 1.40.0-dev.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 6.10.0-dev.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 4.10.0-dev.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 1.10.0-dev.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (the change)
After (the change)
Make sure that you've checked the boxes below before you submit the PR
Steps needed to test
For testing, you can add a border to the newly added styles in
::beforeand visually verify the increased clickable area, as in the screenshot below